Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Add isTypedArray() and isNumericArray() #314

Merged
merged 6 commits into from
Jan 1, 2023
Merged

feat(types): Add isTypedArray() and isNumericArray() #314

merged 6 commits into from
Jan 1, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Dec 22, 2022 •
edited
Loading

ArrayBuffer.isView() interacts poorly with strict typescript, the resulting type after an if statement still doesn't allow indexing etc.

@ibgreen ibgreen merged commit aa529d7 into master Jan 1, 2023
@ibgreen ibgreen deleted the ib/is-typed-array branch January 1, 2023 20:19
ibgreen added a commit that referenced this pull request Jan 1, 2023
@ibgreen
feat(types): Add isTypedArray() and isNumericArray() (#314)
7f785b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen